[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=823311

--- Comment #4 from Kevin Fenzi <kevin at scrye.com> ---

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License GPLv2+ or CC-BY-SA
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. Not a blocker, but might consider shipping the xfce-notify-4.0/ theme too?
Also, lightdm is under review, so might be ready to ship it's theme?

2. If I use the method listed in the spec to get the source, I get: 
shimmerproject-Greybird-v0.8.2-0-g10555c8.tar.gz
but you have 
shimmerproject-Greybird-v0.8.1-9-g10555c8.tar.gz 
(they appear identical, perhaps your versioning is off in the spec?)

3. rpmlint says: 
greybird.src: W: spelling-error Summary(en_US) minimalistic -> minimalist,
minimalism, animistic
greybird.src: W: spelling-error %description -l en_US metacity -> meta city,
meta-city, mendacity
greybird.src: W: spelling-error %description -l en_US grey -> Grey, gray, trey
greybird.src: W: spelling-error %description -l en_US ish -> is, sh, dish
greybird.src: W: invalid-url Source0:
shimmerproject-Greybird-v0.8.1-9-g10555c8.tar.gz
5 packages and 0 specfiles checked; 0 errors, 5 warnings.

All can be ignored.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/package-review/attachments/20120522/c9415915/attachment.html>