[Bug 823724] Review Request: github-cli - command-line interface for GitHub

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=823724

--- Comment #4 from Adrian Alves <aalves at gmail.com> ---
(In reply to comment #3)
> I'm not completely sure about this- but wouldn't it be better to download a
> tarball of the source rather than using git and assuming the version number
> is 1.0.0? Especially when such a tarball is available from
> http://pypi.python.org/pypi/github-cli
> 
> If you use revision control, I think you need to make the version number a
> snapshot-style version number as described here:
> https://fedoraproject.org/wiki/Packaging:SourceURL and
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages
> 
> Is the line below supposed to make sure we have version 1.0.0? From the
> comment, I guess so, but catting this file doesn't actually do anything:
> 
> # cat src/github/version.py (Checkout the release version)
> 
> The only other thing is- this package currently has no documentation. Is
> there any available that could perhaps be included?

I added all the fixes that u suggested:
Spec URL: http://alvesadrian.fedorapeople.org/github-cli.spec
SRPM URL: http://alvesadrian.fedorapeople.org/github-cli-1.0.0-3.fc16.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.