[Bug 872909] Review Request: rubygem-test-unit-rr - Test::Unit::RR - RR adapter for Test::Unit

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=872909

--- Comment #3 from Mamoru TASAKA <mtasaka at fedoraproject.org> ---
Hello:

(In reply to comment #2)
> This is an informal review as I am not sponsored yet.
> > # https://github.com/test-unit/test-unit-rr/issues/1
> 
> This can be removed as upstream indicated LGPLv2+ at
> https://github.com/test-unit/test-unit-rr/issues/1

So I explicitly wrote the URL above to clarify the license
because the upstream clarified the license on the above URL.

> > %description
> > Test::Unit::RR - RR adapter for Test::Unit.
> 
> I think the description should be longer and should contain less programming
> wording. For instance, I don't know what is an RR adapter.

I think using what is written on the metadata directly is
less confusiong.

> > # No test suite available currently
> 
> There should be a %check before that line as this comment is related to the
> %check section.

Writing %check will create %check section unneededly so I don't want
to write it for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.