[Bug 876409] Review Request: perl-Growl-GNTP - Perl implementation of GNTP Protocol (Client Part)

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=876409

Michal Ingeli <mi at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

--- Comment #1 from Michal Ingeli <mi at v3.sk> ---
Picking this one, since it looks like we are working on/packaging same thing.

* spec file clean, in american english
* license ok
* source matches upstream, clean without binaries
* rpmlint silent, package builds

- many BR are redundant and useless, while most of them is pulled in by perl or
automatically generated by rpmbuild. list only what you really need to build
(in mock).
- is there anything to filter out with this?
  %{?perl_default_filter} # Filters (not)shared c libs
- use dos2unix BR rather than this:
  sed -i "s/\r//" README
- specfile is not consistent with provided srpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.