[Bug 868931] Review Request: sshuttle - Transparent Proxy VPN

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=868931

--- Comment #10 from Volker Fröhlich <volker27 at gmx.at> ---
The files you install to /usr/lib should go to %{_datadir} instead.

Please inform upstream of the (long) outdated FSF postal address in LICENSE, if
you haven't done so yet.

You might be better off, making the version 0 and add the date in front of the
git hash. Otherwise, if a version 0.5, 1.0 or whatever comes out, you'd have to
use epochs to make it newer than 20121019.

The Documentation directory contains a manpage. Rather install that instead of
including Documentation/sshuttle.md.

Please include the complete commands to create the tarball.

You don't have to BR "make". On the one hand, I think you're not using it; on
the other hand it's an exception:
http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

-- 
You are receiving this mail because:
You are on the CC list for the bug.