[Bug 862293] Review Request: wsl - shell based wsman client.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=862293

Mario Blättermann <mario.blaettermann at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann at gmail.co
                   |                            |m

--- Comment #1 from Mario Blättermann <mario.blaettermann at gmail.com> ---
Some initial comments, based on the rpmlint output:

$ rpmlint -i -v *
wsl.src: I: checking
wsl.src: W: spelling-error Summary(en_US) Wsman -> Osman, Woman, Newsman
The value of this tag appears to be misspelled. Please double-check.

wsl.src: W: non-standard-group System/Management
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
"Applications/Communications", "Applications/Databases",
"Applications/Editors", "Applications/Emulators", "Applications/Engineering",
"Applications/File", "Applications/Internet", "Applications/Multimedia",
"Applications/Productivity", "Applications/Publishing", "Applications/System",
"Applications/Text", "Development/Debug", "Development/Debuggers",
"Development/Languages", "Development/Libraries", "Development/System",
"Development/Tools", "Documentation", "System Environment/Base", "System
Environment/Daemons", "System Environment/Kernel", "System
Environment/Libraries", "System Environment/Shells", "Unspecified", "User
Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

wsl.src: I: checking-url http://linux.dell.com/files/wsl (timeout 10 seconds)
wsl.src: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages.  Add the section, even if empty.

wsl.src: I: checking-url http://linux.dell.com/files/wsl/wsl-0.1.7c.tar.gz
(timeout 10 seconds)
wsl.src: W: invalid-url Source0:
http://linux.dell.com/files/wsl/wsl-0.1.7c.tar.gz HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

wsl.spec:6: W: non-standard-group System/Management
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
"Applications/Communications", "Applications/Databases",
"Applications/Editors", "Applications/Emulators", "Applications/Engineering",
"Applications/File", "Applications/Internet", "Applications/Multimedia",
"Applications/Productivity", "Applications/Publishing", "Applications/System",
"Applications/Text", "Development/Debug", "Development/Debuggers",
"Development/Languages", "Development/Libraries", "Development/System",
"Development/Tools", "Documentation", "System Environment/Base", "System
Environment/Daemons", "System Environment/Kernel", "System
Environment/Libraries", "System Environment/Shells", "Unspecified", "User
Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

wsl.spec: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages.  Add the section, even if empty.

wsl.spec: I: checking-url http://linux.dell.com/files/wsl/wsl-0.1.7c.tar.gz
(timeout 10 seconds)
wsl.spec: W: invalid-url Source0:
http://linux.dell.com/files/wsl/wsl-0.1.7c.tar.gz HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 1 specfiles checked; 0 errors, 7 warnings.


And some more issues from me:

A "Vendor" tag is not needed. Please remove it.

%doc
%{_defaultdocdir}/%{name}-%{version}

This is at least unusual, but probably wrong. You don't have to define the doc
folder. Just write:

%doc LICENSE README-wsl VERSION


If you don't want to provide your package for EPEL 5, you have to remove some
obsolete stuff (BuildRoot definition, %clean section, initial cleaning of
buildroot in %install). The %defattr line is obsolete anyway, even for EPEL 5.
Please remove it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.