[Bug 833226] Review Request: python-pycparser - C parser and AST generator written in Python

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=833226

Jos de Kloe <josdekloe at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josdekloe at gmail.com

--- Comment #1 from Jos de Kloe <josdekloe at gmail.com> ---
rpmbuild -ba runs fine

rpmlint  python-pycparser-2.07-1.fc17.src.rpm
python-pycparser.src: W: strange-permission remove-relative-sys-path 0755L
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

reproduces your result.

rpmlint python-pycparser-2.07-1.fc17.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

seems fine.

Two different styles of macros are mixed in this spec file, i.e.: %{__python}
versus $RPM_BUILD_ROOT

please choose a consistent style, i.e. use: %{buildroot}
(see http://fedoraproject.org/wiki/Packaging:Guidelines,
 1.35.1 Using %{buildroot} and %{optflags} vs $RPM_BUILD_ROOT and
$RPM_OPT_FLAGS)

I noticed the spec file runs dos2unix to convert line-endings in examples
files, and it also runs a custom python script to delete unwanted boilerplate
sys.path lines in the examples dir.

Looking at
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Scripting_inside_of_spec_files
this seems fine to me.

Since all python files in this package are in the module directory pycparser I
think it would be better to be more explicit and to have
%{python_sitelib}/pycparser/ in stead of %{python_sitelib}/* in the %files
section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.