[Bug 839653] Review Request: rubygem-slim - Slim is a template language

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=839653

--- Comment #12 from Troy Dawson <tdawson at redhat.com> ---
Very close.  I am only getting one problem, it's in the rpmlint section.

Rpmlint
-------
Checking: rubygem-slim-doc-1.2.2-6.fc19.noarch.rpm
          rubygem-slim-1.2.2-6.fc19.noarch.rpm
          rubygem-slim-1.2.2-6.fc19.src.rpm
rubygem-slim-doc.noarch: E: non-executable-script
/usr/share/gems/gems/slim-1.2.2/benchmarks/profile-render.rb 0644L /usr/bin/env
rubygem-slim-doc.noarch: E: non-executable-script
/usr/share/gems/gems/slim-1.2.2/benchmarks/run-benchmarks.rb 0644L /usr/bin/env
rubygem-slim-doc.noarch: E: non-executable-script
/usr/share/gems/gems/slim-1.2.2/benchmarks/profile-parser.rb 0644L /usr/bin/env
rubygem-slim.noarch: W: no-manual-page-for-binary slimrb
rubygem-slim.src:63: W: macro-in-comment %{SOURCE0}
3 packages and 0 specfiles checked; 3 errors, 2 warnings.

It looks like if you add

grep -rl /usr/bin/env %{buildroot}%{gem_instdir}/benchmarks  | xargs chmod a+x

that should fix it up.  And if Vit has no objections, I'll approve it.

Getting rid of that #%{SOURCE0} would make things even better, but it's not so
important that I won't approve it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.