[Bug 818629] Review Request: rubygem-delayed_job_active_record - ActiveRecord back-end for DelayedJob

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=818629

--- Comment #2 from Vít Ondruch <vondruch at redhat.com> ---
Thank you for looking into this package. Here is its updated version:

Spec URL:
http://people.redhat.com/vondruch/rubygem-delayed_job_active_record.spec
SRPM URL:
http://people.redhat.com/vondruch/rubygem-delayed_job_active_record-0.3.3-1.fc19.src.rpm



(In reply to comment #1)
> 2, The version of the gem in the spec file is 0.3.2, but 0.3.3 is already
> out: 
> 
> `gem fetch delayed_job_active_record`
> `Fetching: delayed_job_active_record-0.3.3.gem (100%)`
> 
> It's recommended to always build for the latest upstream release if
> available.

Yes, the .spec file was laying around for some time. I updated it to the latest
version.

> 3, Running:
> 
> `mock -r fedora-rawhide-x86_64
> rubygem-delayed_job_active_record-0.3.2-1.fc19.src.rpm` raises an exception,
> in the build.log I found a failing test:
> ```
> + rspec spec
> DEPRECATION WARNING: Calling set_primary_key is deprecated. Please use
> `self.primary_key = 'the_name'` instead. (called from <class:Story> at
> /builddir/build/BUILD/rubygem-delayed_job_active_record-0.3.2/usr/share/gems/
> gems/delayed_job_active_record-0.3.2/spec/spec_helper.rb:43)
> ............................................................F................
> Failures:
>   1) Delayed::Backend::ActiveRecord::Job it should behave like a delayed_job
> backend worker integration failed jobs should re-schedule jobs after failing
>      Failure/Error: @job.attempts.should == 1
>        expected: 1
> ```
> 
> This also happens when building using mock for fedora-18-x86_64.

Weird. You can see from the attached Koji link that the test suite used to
pass. However, it was probably against Rails 3.0 at that time. I was not able
to locate the issue, so I have reported it upstream:
https://github.com/collectiveidea/delayed_job_active_record/issues/24

-- 
You are receiving this mail because:
You are on the CC list for the bug.