[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=853514

--- Comment #8 from Guillermo Gómez <guillermo.gomez at gmail.com> ---
Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
[x]: Package contains Requires: ruby(abi).
See: http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_ABI
[!]: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.

See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

Please fix:

Replace 
%{gem_instdir}/COPYING 

with
%doc %{gem_instdir}/COPYING 

[!]: Specfile should use macros from rubygem-devel package.
     Note: The specfile doesn't use following macro: %doc %{gem_docdir}

Please use %{gem_docdir} in 

%doc %{gem_dir}/doc   << actually wrong, claiming ownership of
/usr/share/rubygems/doc

Replace with which points to the right files.

%doc %{gem_docdir}

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[ ]: Large documentation files are in a -doc subpackage, if required.
[!]: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
     Provides are present.
[x]: Package must own all directories that it creates.
[!]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.

Ruby:
[x]: Gem package must not define a non-gem subpackage
[ ]: Platform dependent files must all go under %{gem_extdir}, platform
independent under %{gem_dir}.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package contains Requires: ruby(abi).

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Latest version is packaged.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define.

Ruby:
[x]: Gem package should exclude cached Gem.
[!]: Specfile should use macros from rubygem-devel package.
     Note: The specfile doesn't use these macros: %doc %{gem_docdir}

Please use %{gem_docdir} in 

%doc %{gem_dir}/doc   << actually wrong, claiming ownership of
/usr/share/rubygems/doc

%doc %{gem_docdir}

[x]: Test suite should not be run by rake.
[!]: Test suite of the library should be run.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Rpmlint
-------
Checking: rubygem-clouddb-doc-0.0.1-2.fc17.noarch.rpm
          rubygem-clouddb-0.0.1-2.fc17.src.rpm
          rubygem-clouddb-0.0.1-2.fc17.noarch.rpm
rubygem-clouddb.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

No documentation waring should go away after tagging COPYING file as %doc.

Rpmlint (installed packages)
----------------------------
# rpmlint rubygem-clouddb rubygem-clouddb-doc
rubygem-clouddb.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'

-- 
You are receiving this mail because:
You are on the CC list for the bug.