[Bug 863795] Review Request: kadu - An Gadu-Gadu client for online messaging

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=863795

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #1 from Volker Fröhlich <volker27 at gmx.at> ---
Use %global instead of %define.

There's a libiris bundle. Rex managed to create a separate package:
https://bugzilla.redhat.com/show_bug.cgi?id=749885

Don't BR phonon, sqlite and the likes. Only BR the devel sub-packages.

Since you can't go for EPEL 5, please remove buildroot definition, clean
section and the first rm in the install section. defattr is no longer necessary
either.

What's the idea of having -k with make?

I can't see why several sub-packages should be GPLv3+. Sub-packages should use
the ?_isa macro when requiring the base package.

You can use the name macro in Source0. You can drop "-n kadu-%{version}" from
the setup macro.

I noticed this warning:

+ desktop-file-install --vendor fedora --delete-original --dir
/home/makerpm/rpmbuild/BUILDROOT/kadu-0.12.2-1.fc16.x86_64/usr/share/applications
/home/makerpm/rpmbuild/BUILDROOT/kadu-0.12.2-1.fc16.x86_64/usr/share/applications/kadu.desktop
/home/makerpm/rpmbuild/BUILDROOT/kadu-0.12.2-1.fc16.x86_64/usr/share/applications/fedora-kadu.desktop:
warning: value "Instant Messenger" for key "Comment" in group "Desktop Entry"
looks redundant with value "Instant Messenger" of key "GenericName"
/home/makerpm/rpmbuild/BUILDROOT/kadu-0.12.2-1.fc16.x86_64/usr/share/applications/fedora-kadu.desktop:
warning: value "Komunikator internetowy" for key "Comment[pl]" in group
"Desktop Entry" looks redundant with value "Komunikator internetowy" of key
"GenericName[pl]"

The locales are not handled properly, please compare
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

I personally consider the files section a bit over-detailled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.