[Bug 846913] Review Request: libcommuni - Communi is a cross-platform IRC client library written with Qt 4
bugzilla at redhat.com
bugzilla at redhat.com
Wed Sep 5 13:24:24 UTC 2012
https://bugzilla.redhat.com/show_bug.cgi?id=846913
--- Comment #25 from Dan Mashal <dan.mashal at gmail.com> ---
Please look at the must items and rpmlint items below. This is very close to
approval.
Package Review
==============
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST ldconfig called in %post and %postun if required.
[x]: MUST Package does not contain any libtool archives (.la)
[ ]: MUST Package does not contain kernel modules.
[ ]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Development (unversioned) .so files in -devel subpackage, if
present.
==== Generic ====
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[ ]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[ ]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr(....) present in %files devel section. This is OK if
packaging for EPEL5. Otherwise not needed
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[!]: MUST Package installs a %{name}.desktop using desktop-file-install if
there is such a file.
[ ]: MUST Development files must be in a -devel package
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[ ]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2 or later)", "GPL (v2 or later)", "LGPL (v3 or later)", "MPL
(v1.1) GPL (unversioned/unknown version)", "LGPL (v2.1 or later)" For
detailed output of licensecheck see file:
/home/dan/846913-libcommuni/licensecheck.txt
[ ]: MUST License file installed when any subpackage combination is installed.
[ ]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[ ]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[ ]: MUST Package is not relocatable.
[ ]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[ ]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL5 is required
[ ]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[ ]: SHOULD Package functions as described.
[ ]: SHOULD Latest version is packaged.
[ ]: SHOULD Package does not include license text files separate from
upstream.
[ ]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
[ ]: SHOULD Scriptlets must be sane, if used.
[x]: SHOULD SourceX tarball generation or download is documented.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Patch0 (desktop.patch) Source0 (communi-1.1.2.tar.gz)
[x]: SHOULD SourceX is a working URL.
[ ]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[ ]: SHOULD %check is present and all tests pass.
[ ]: SHOULD Packages should try to preserve timestamps of original installed
files.
[!]: SHOULD Spec use %global instead of %define.
Note: %define tardirname communi-communi-939dc37
Issues:
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr(....) present in %files devel section. This is OK if
packaging for EPEL5. Otherwise not needed
See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
[!]: MUST Package installs a %{name}.desktop using desktop-file-install if
there is such a file.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
Rpmlint
-------
Checking: communi-1.1.2-1.fc17.x86_64.rpm
libcommuni-1.1.2-1.fc17.src.rpm
libcommuni-debuginfo-1.1.2-1.fc17.x86_64.rpm
libcommuni-1.1.2-1.fc17.x86_64.rpm
libcommuni-devel-1.1.2-1.fc17.x86_64.rpm
communi.x86_64: W: obsolete-not-provided libircclient-qt-devel
communi.x86_64: W: no-manual-page-for-binary communi
libcommuni.src: W: spelling-error %description -l en_US Communi -> Commune,
Comm uni, Comm-uni
libcommuni.x86_64: W: spelling-error %description -l en_US Communi -> Commune,
Comm uni, Comm-uni
libcommuni.x86_64: W: obsolete-not-provided libircclient-qt
libcommuni-devel.x86_64: W: obsolete-not-provided libircclient-qt-devel
5 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint libcommuni-devel libcommuni-debuginfo
libcommuni-devel.x86_64: W: obsolete-not-provided libircclient-qt-devel
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'
Requires
--------
communi-1.1.2-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
libCommuni.so.1()(64bit)
libQtCore.so.4()(64bit)
libQtDBus.so.4()(64bit)
libQtGui.so.4()(64bit)
libQtNetwork.so.4()(64bit)
libQtXml.so.4()(64bit)
libc.so.6()(64bit)
libcommuni(x86-64) = 1.1.2-1.fc17
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
rtld(GNU_HASH)
libcommuni-debuginfo-1.1.2-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
libcommuni-1.1.2-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
/sbin/ldconfig
libQtCore.so.4()(64bit)
libQtNetwork.so.4()(64bit)
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
rtld(GNU_HASH)
libcommuni-devel-1.1.2-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
libCommuni.so.1()(64bit)
libQtCore.so.4()(64bit)
libQtDeclarative.so.4()(64bit)
libQtGui.so.4()(64bit)
libQtNetwork.so.4()(64bit)
libQtScript.so.4()(64bit)
libQtSql.so.4()(64bit)
libQtSvg.so.4()(64bit)
libQtXmlPatterns.so.4()(64bit)
libc.so.6()(64bit)
libcommuni(x86-64) = 1.1.2-1.fc17
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
rtld(GNU_HASH)
Provides
--------
communi-1.1.2-1.fc17.x86_64.rpm:
communi = 1.1.2-1.fc17
communi(x86-64) = 1.1.2-1.fc17
libcommuni-debuginfo-1.1.2-1.fc17.x86_64.rpm:
libcommuni-debuginfo = 1.1.2-1.fc17
libcommuni-debuginfo(x86-64) = 1.1.2-1.fc17
libcommuni-1.1.2-1.fc17.x86_64.rpm:
libCommuni.so.1()(64bit)
libcommuni = 1.1.2-1.fc17
libcommuni(x86-64) = 1.1.2-1.fc17
libcommuni-devel-1.1.2-1.fc17.x86_64.rpm:
libcommuni-devel = 1.1.2-1.fc17
libcommuni-devel(x86-64) = 1.1.2-1.fc17
libcommuniplugin.so()(64bit)
MD5-sum check
-------------
http://github.com/communi/communi/tarball/v1.1.2/communi-1.1.2.tar.gz :
CHECKSUM(SHA256) this package :
7f319f79e5505e3409ae481ac21637e30ad9cfb909b93629bd4feb63def4482f
CHECKSUM(SHA256) upstream package :
7f319f79e5505e3409ae481ac21637e30ad9cfb909b93629bd4feb63def4482f
Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09
Command line :/usr/bin/fedora-review -b 846913
External plugins:
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the package-review
mailing list