[Bug 847817] Review Request: libestr - A library to handle strings

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=847817

--- Comment #4 from Michael Schwendt <mschwendt at gmail.com> ---
* Version 0.1.4 has been released. Not necessary to package it during review,
just mentioning it.


> %build
> make %{?_smp_mflags}

V=1 make ...    for more verbose build output would be beneficial. Else you
don't get to see the compiler flags etc.


> make install -p DESTDIR=%{buildroot}

As in the related reviews, there's a mistake in how -p is added here. Should
become:

make install INSTALL="install -p" DESTDIR=%{buildroot}


> checking how to associate runtime and link libraries... printf %s\n

That's a strange message in the "configure" output. Something's broken there.
Unrelated to the review, just mentioning it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.