[Bug 858060] qpid-snmpd - SNMP agent for qpid broker

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=858060

--- Comment #2 from Ernie <eallen at redhat.com> ---
SPEC URL:
http://eallen.fedorapeople.org/qpid-snmpd/1.0.0-2.fc17/qpid-snmpd.spec
SRPM URL:
http://eallen.fedorapeople.org/qpid-snmpd/1.0.0-2.fc17/qpid-snmpd-1.0.0-2.fc17.src.rpm

Please note that the spec and srpm locations have changed.

Thanks Darryl.
>[!]  MUST: Permissions on files must be set properly. Executables should be >set with executable permissions, for example. [15]
>
>Two different methods are used to install files in the %install section: cp >and install, with the former leaving permissions unverified.
>Please use install consistently.

Done

>[!]  MUST: Each package must consistently use macros. [16]
>
>1) See above note regarding the location of the license.txt and README.txt. 
>
>2) The use of the %{_build_dir} is confusing since it could be misread as an >alias for %{buildroot}. Instead, please use %{buildroot} and use "%setup -q -c >%{name}-%{version}" to explode the sources.

I've changed the directory into which the source is exploded (in the zip file).
Before it was the same name as the app (qpid-snmpd). That caused naming
problems. I've changed the name of the global to avoid confusion with the
%{builddir}

>[!]  MUST: A package must own all directories that it creates. If it does not >create a directory that it uses, then it should require a package which does >create that directory. [13]
>
>The two %doc files are not in proper locations, but are instead listed as >being in %{_build_dir} in the %files section.
>They should instead use %{_docdir}/%{name}-%{version}

Sorry, but I'm confused by this. When installed, the current rpm puts the
README.txt and license.txt files in the /usr/share/doc/qpid-snmpd-1.0.0
directory. Is that not correct? The lines in the spec file use the %doc macro
to do the install so they are put in the proper location. They just reference
the %{buildroot} relative location of the files as the source location. Should
I change the source location? 

Also, even though you accepted the rpmlint warnings, is there anything I can do
to get rid of them?

-- 
You are receiving this mail because:
You are on the CC list for the bug.