[Bug 807810] Review Request: ptpd-phc - Precision Time Protocol daemon

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=807810

--- Comment #6 from Jon Stanley <jstanley at rmrf.net> ---
A few quick comments.

The comments in the spec file aren't exactly revealing as to how to reproduce
*this exact* tarball. In the event that upstream were to actually update this
thing (which seems somewhat unlikely given the git history), What I'd get by
following your instructions is whatever the latest thing is - not what's in
this package. For example from one of my packages:

# Upstream does not provide tarballs.
# To generate:
# git clone git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git
# cd trace-cmd
# git archive --prefix=trace-cmd-%%{version}.%%{checkout}/ -o
trace-cmd-%%{version}.%%{checkout}.tar.gz %%{git_commit}


Secondly, the standard %{optflags} aren't used. In the same patch where you
drop the kernel includes, you could just as easily add $(CFLAGS) to the
Makefile and do make CFLAGS=%{optflags}

Thirdly, the debuginfo that is generated is useless - the binary is compiled
without -g.

-- 
You are receiving this mail because:
You are on the CC list for the bug.