[Bug 859270] Review Request: php-symfony2-Filesystem - Symfony2 Filesystem Component

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=859270

Remi Collet <rcollet at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rcollet at redhat.com

--- Comment #1 from Remi Collet <rcollet at redhat.com> ---
Quick notes, which affects "all" synfony 2.1 packages

- phpunit.xml.dist and Tests/* sould be role="test", so install in
%{pear_testdir}
- CHANGELOG.md should be role="doc" 

sed -e '/CHANGELOG.md/s/role="php"/role="doc"/' \
    -e '/phpunit.xml.dist/s/role="php"/role="test"/' \
    -e '/Tests/s/role="php"/role="test"/' \
    -i package.xml

Of course, this should be reported to upstream

- as tests are provided, should be run in %check

%check
cd %{pear_name}-%{version}/Symfony/Component/%{pear_name}/Tests
phpunit  --bootstrap bootstrap.php .

N.B. : Yaml could not run test in %check, because it depends on phpunit, which
depends use Yaml (see the diff I sent you)

-- 
You are receiving this mail because:
You are on the CC list for the bug.