[Bug 856002] Review Request: plug - Linux software for Fender Mustang amplifiers

Sun Sep 30 19:30:36 UTC 2012

https://bugzilla.redhat.com/show_bug.cgi?id=856002

--- Comment #4 from Jonathan Underwood <jonathan.underwood at gmail.com> ---
Spec URL: http://fedorapeople.org/~jgu/plug.spec
SRPM URL: http://fedorapeople.org/~jgu/plug-1.1-5.fc17.src.rpm

* Sun Sep 30 2012 Jonathan G. Underwood <jonathan.underwood at gmail.com> - 1.1-5
- Change Group to Applications/System
- Untabify spec file
- Fix Source URL

(In reply to comment #3)
> Scratch build:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=4525705
> 
> $ rpmlint -i -v *
> plug.src: I: checking
> plug.src: W: non-standard-group Hardware/Other
> The value of the Group tag in the package is not valid.  Valid groups are:
> "Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
> "Applications/Communications", "Applications/Databases",
> "Applications/Editors", "Applications/Emulators", "Applications/Engineering",
> "Applications/File", "Applications/Internet", "Applications/Multimedia",
> "Applications/Productivity", "Applications/Publishing",
> "Applications/System",
> "Applications/Text", "Development/Debug", "Development/Debuggers",
> "Development/Languages", "Development/Libraries", "Development/System",
> "Development/Tools", "Documentation", "System Environment/Base", "System
> Environment/Daemons", "System Environment/Kernel", "System
> Environment/Libraries", "System Environment/Shells", "Unspecified", "User
> Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".
> 

Changed group to Applications/System

> plug.src: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds)
> plug.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12)
> The specfile mixes use of spaces and tabs for indentation, which is a
> cosmetic
> annoyance.  Use either spaces or tabs for indentation, not both.
> 

Fixed.

> plug.src: I: checking-url http://piorekf.org/plug/download/v1.1.tar.gz
> (timeout 10 seconds)
> plug.src: W: invalid-url Source0:
> http://piorekf.org/plug/download/v1.1.tar.gz HTTP Error 404: Not Found
> The value should be a valid, public HTTP, HTTPS, or FTP URL.
> 

Fixed.

> plug.i686: I: checking
> plug.i686: W: non-standard-group Hardware/Other
> The value of the Group tag in the package is not valid.  Valid groups are:
> "Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
> "Applications/Communications", "Applications/Databases",
> "Applications/Editors", "Applications/Emulators", "Applications/Engineering",
> "Applications/File", "Applications/Internet", "Applications/Multimedia",
> "Applications/Productivity", "Applications/Publishing",
> "Applications/System",
> "Applications/Text", "Development/Debug", "Development/Debuggers",
> "Development/Languages", "Development/Libraries", "Development/System",
> "Development/Tools", "Documentation", "System Environment/Base", "System
> Environment/Daemons", "System Environment/Kernel", "System
> Environment/Libraries", "System Environment/Shells", "Unspecified", "User
> Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".
> 
> plug.i686: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds)
> plug.i686: W: only-non-binary-in-usr-lib
> There are only non binary files in /usr/lib so they should be in /usr/share.
> 

This is a false positive - the file under /usr/lib is a udev rule file which
absolutely must go in /usr/lib/udev/rules.d/

> plug.i686: W: no-manual-page-for-binary plug
> Each executable in standard binary directories should have a man page.
> 
> plug.x86_64: I: checking
> plug.x86_64: W: non-standard-group Hardware/Other
> The value of the Group tag in the package is not valid.  Valid groups are:
> "Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
> "Applications/Communications", "Applications/Databases",
> "Applications/Editors", "Applications/Emulators", "Applications/Engineering",
> "Applications/File", "Applications/Internet", "Applications/Multimedia",
> "Applications/Productivity", "Applications/Publishing",
> "Applications/System",
> "Applications/Text", "Development/Debug", "Development/Debuggers",
> "Development/Languages", "Development/Libraries", "Development/System",
> "Development/Tools", "Documentation", "System Environment/Base", "System
> Environment/Daemons", "System Environment/Kernel", "System
> Environment/Libraries", "System Environment/Shells", "Unspecified", "User
> Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".
> 

Fixed.

> plug.x86_64: I: checking-url http://piorekf.org/plug/ (timeout 10 seconds)
> plug.x86_64: W: only-non-binary-in-usr-lib
> There are only non binary files in /usr/lib so they should be in /usr/share.
> 

False positive - see above.

> plug.x86_64: W: no-manual-page-for-binary plug
> Each executable in standard binary directories should have a man page.
> 

This is a graphical application with no command line switches. A man page
really isn't necessary.

> plug-debuginfo.i686: I: checking
> plug-debuginfo.i686: I: checking-url http://piorekf.org/plug/ (timeout 10
> seconds)
> plug-debuginfo.x86_64: I: checking
> plug-debuginfo.x86_64: I: checking-url http://piorekf.org/plug/ (timeout 10
> seconds)
> plug.spec:5: W: non-standard-group Hardware/Other
> The value of the Group tag in the package is not valid.  Valid groups are:
> "Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
> "Applications/Communications", "Applications/Databases",
> "Applications/Editors", "Applications/Emulators", "Applications/Engineering",
> "Applications/File", "Applications/Internet", "Applications/Multimedia",
> "Applications/Productivity", "Applications/Publishing",
> "Applications/System",
> "Applications/Text", "Development/Debug", "Development/Debuggers",
> "Development/Languages", "Development/Libraries", "Development/System",
> "Development/Tools", "Documentation", "System Environment/Base", "System
> Environment/Daemons", "System Environment/Kernel", "System
> Environment/Libraries", "System Environment/Shells", "Unspecified", "User
> Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".
> 

Fixed.

> plug.spec:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12)
> The specfile mixes use of spaces and tabs for indentation, which is a
> cosmetic
> annoyance.  Use either spaces or tabs for indentation, not both.
> 

Fixed.

> plug.spec: I: checking-url http://piorekf.org/plug/download/v1.1.tar.gz
> (timeout 10 seconds)
> plug.spec: W: invalid-url Source0:
> http://piorekf.org/plug/download/v1.1.tar.gz HTTP Error 404: Not Found
> The value should be a valid, public HTTP, HTTPS, or FTP URL.
> 

Fixed.

> 5 packages and 1 specfiles checked; 0 errors, 12 warnings.
> 
> 
> 
> The "Group" tag is invalid. Either use one of those mentioned above, or
> remove it, if you don't want to provide your package for EPEL (see
> http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag).
> 

As noted above, I changed it to Applications/System so as to make it easy for
someone to create an EPEL branch (I probably won't).

> Don't mix spaces and tabs. I recommend spaces because this way the spec file
> looks the same in any text editor, independent from the configured tab width.

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.