[Bug 851267] Review Request: arc-gui-clients - ARC Graphical Clients
bugzilla at redhat.com
bugzilla at redhat.com
Thu Apr 25 16:48:46 UTC 2013
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851267
Volker Fröhlich <volker27 at gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #15 from Volker Fröhlich <volker27 at gmx.at> ---
There are a couple of compiler warnings. Maybe you can work with upstream to
get rid of some of them.
The file headers contain no license declarations. I assume ASL 2.0 is correct.
I assume you're not shipping the generated documentation on purpose. I started
the applications and "Help" seemingly lead me to the online help. I guess
that's fine.
This package is APPROVED.
Package Review
==============
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/makerpm/851267-arc-gui-clients/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: update-desktop-database is invoked when required
Note: desktop file(s) in arc-gui-clients
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
All applications launched and I clicked around a bit.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
PPC and ARM succeed as well
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: arc-gui-clients-0.4.3-2.fc20.x86_64.rpm
arc-gui-clients.x86_64: W: spelling-error %description -l en_US middleware ->
middle ware, middle-ware, middleweight
arc-gui-clients.x86_64: W: no-manual-page-for-binary arcsub-ui
arc-gui-clients.x86_64: W: no-manual-page-for-binary arccert-ui
arc-gui-clients.x86_64: W: no-manual-page-for-binary arcproxy-ui
arc-gui-clients.x86_64: W: no-manual-page-for-binary arcstat-ui
arc-gui-clients.x86_64: W: no-manual-page-for-binary arcstorage-ui
1 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint arc-gui-clients
arc-gui-clients.x86_64: W: spelling-error %description -l en_US middleware ->
middle ware, middle-ware, middleweight
arc-gui-clients.x86_64: W: no-manual-page-for-binary arcsub-ui
arc-gui-clients.x86_64: W: no-manual-page-for-binary arccert-ui
arc-gui-clients.x86_64: W: no-manual-page-for-binary arcproxy-ui
arc-gui-clients.x86_64: W: no-manual-page-for-binary arcstat-ui
arc-gui-clients.x86_64: W: no-manual-page-for-binary arcstorage-ui
1 packages and 0 specfiles checked; 0 errors, 6 warnings.
# echo 'rpmlint-done:'
Requires
--------
arc-gui-clients (rpmlib, GLIBC filtered):
libQtCore.so.4()(64bit)
libQtGui.so.4()(64bit)
libQtNetwork.so.4()(64bit)
libQtSql.so.4()(64bit)
libQtWebKit.so.4()(64bit)
libQtXml.so.4()(64bit)
libQtXmlPatterns.so.4()(64bit)
libarccommon.so.2()(64bit)
libarccommunication.so.2()(64bit)
libarccompute.so.2()(64bit)
libarccredential.so.2()(64bit)
libarccredentialstore.so.2()(64bit)
libarccrypto.so.2()(64bit)
libarcdata.so.2()(64bit)
libarcloader.so.2()(64bit)
libarcmessage.so.2()(64bit)
libc.so.6()(64bit)
libcrypto.so.10()(64bit)
libcrypto.so.10(libcrypto.so.10)(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libglib-2.0.so.0()(64bit)
libglibmm-2.4.so.1()(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
libsigc-2.0.so.0()(64bit)
libssl.so.10()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libxml2.so.2()(64bit)
rtld(GNU_HASH)
Provides
--------
arc-gui-clients:
arc-gui-clients
arc-gui-clients(x86-64)
MD5-sum check
-------------
http://downloads.sourceforge.net/arc-gui-clients/arc-gui-clients-0.4.3-Source.tar.gz
:
CHECKSUM(SHA256) this package :
03f914737abd7fdea2ccfe70a57e8f58d56a98477fffe71f9b7504d2fcce2806
CHECKSUM(SHA256) upstream package :
03f914737abd7fdea2ccfe70a57e8f58d56a98477fffe71f9b7504d2fcce2806
Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 851267
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BQBCpauekL&a=cc_unsubscribe
More information about the package-review
mailing list