[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=990544



--- Comment #5 from Palle Ravn <ravnzon at gmail.com> ---
(In reply to Christopher Meng from comment #3)
> Note if you split out devel package, don't include static libs.
> 
> 1. Please remove them via some commands like this:
> 
> find %{buildroot} -name '*.*a' -delete

All static libs should be removed now.

> 2. Don't adda BR of gcc-c++, please remove.

Done.

> 3. You'd better add isa macro to devel package Requires:
> 
> Requires:	   %{name}%{?_isa} = %{version}-%{release}

Done.

> 4. This package has bundled many libraries.
> 
> GPL (v2 or later) (with incorrect FSF address)
> ----------------------------------------------
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/mangler-1.2.5/
> libventrilo3/ventrilo3_handshake.c
> /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/mangler-1.2.5/
> libventrilo3/ventrilo_algo.h

Using rpmlint I only get an FSF address error from the debug rpm, only listing
the file ventrilo3_handshake.c. However, the license should still be okay as it
is GPLv3. If I notify upstream about the incorrect addresses this should not be
a blocker.

> 5. This package has iphone and android files, I don't know if they are
> useful or not? Because licensecheck has found many license issues, but most
> are those files, so I have this question.

I can remove those, but it doesn't change anything in the final RPM. Likewise,
the source RPM also includes the android and iphone files, as it contains the
original tar file.

(In reply to Michael Schwendt from comment #4)
> > This is from libventrilo, which hasn't been packaged yet in Fedora.
> > 
> > https://github.com/haxar/libventrilo3
> 
> It's part of the Mangler project, isn't it?
> https://github.com/haxar?tab=repositories
> 
> Find out about the release cycle of this lib. Is it updated often and
> separately from Mangler? Else you could make the mangler.src.rpm build
> libventrilo3 and libventrilo3-devel packages, so if anything else wants to
> build with the lib, it would be available. There could still be a separate
> libventrilo3.src.rpm be added to the package collection at a later point
> (and depending on how upstream maintains these components).

It is part of Mangler and I can't find anyone else using this library. If it is
not strictly required to have a separate library package, I would keep
libventrilo3 and mangler in the same package, and split it up later if
necessary.  

> > Requires:       gtkmm24 speex gsm espeak xosd
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

Removed.

> > %{_datadir}/applications/mangler.desktop
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-
> install_usage

Now running desktop-file-validate as part of %install.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rMnMhL778i&a=cc_unsubscribe