[Bug 987738] Review Request: dput - Debian package upload tool

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=987738



--- Comment #4 from Ed Santiago <santiago at redhat.com> ---
[ disclaimer#1: I'm not a packager yet; I'm just trying to learn the ropes ]
[ disclaimer#2: total n00b, so my interpretation of the guidelines may be off ]

That said...

1. Thanks for removing the %config. I'm pretty sure that's the right thing to
do, and the rpmlint non-conffile-in-etc warning is ignorable.

2. Thanks.

3. I'm sorry, I was totally, embarrassedly confused about directory ownership.
Your original mkdirs were in fact fine, and probably preferable to the mix of
-D in some but not all install commands. Again, I'm really sorry for my
confusion. But:

4. You removed the gzip actions, and changed the man page install commands to
write .gz files. I do not think that does what you think it does. (As in: yes,
the files are named .gz, but they are not actually gzip'ed).

Also, your -2 srpm seems to be corrupt (cpio: premature end of file). The
sha1sum of my download is f33fce1a2cb4faab5504cc663649ca0ed0f4e63c.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M2ItHCIs5T&a=cc_unsubscribe