[Bug 989143] Review Request: rubygem-charlock_holmes - Character encoding detecting library for Ruby using ICU

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=989143



--- Comment #4 from Axilleas Pipinellis <axilleas at archlinux.gr> ---
> - The -doc package should not require /usr/bin/env. This is side-effect from
>   RPM processing the shebang line "#!/usr/bin/env python" in
>   test/fixtures/laholator.py. The following line will fix it:
> 
>   %global __requires_exclude ^/usr/bin/env$
> 
>   See https://github.com/axilleas/fedora/pull/5  :)
> 

Thanks for the PR :) Some (many) questions about this.

1. Is this mentioned somewhere in the Packaging guidelines? After declaring
this %global do I still need to remove the shebang (I would guess yes, see 2)?
And if so, this %global is only for fixing the RPM's autorequires?

2. I tried to to make the file executable in %install. Would it be better if I
removed the shebang in %prep instead?
In general is it preferred to remove the shebang from executables rather than
`chmod +x` them?


> - Please remove the whitespace line at the top of %description. For some
> reason
>   gem2rpm has put an extra line there before the text, and that actually does
>   show up in the rpm -qpi.
> 

Nice catch, fixed ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UpM1w08KXo&a=cc_unsubscribe