[Bug 961237] Review Request: sipxtapi - SIP stack and real-time media framework

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=961237



--- Comment #20 from Michael Schwendt <bugs.michael at gmx.net> ---
Created attachment 784745
  --> https://bugzilla.redhat.com/attachment.cgi?id=784745&action=edit
licensecheck.txt done by fedora-review tool

"fedora-review -b 961237" complains about a few things, not limited to the
src.rpm containing a spec file different from the separately linked spec file.

The license headers it finds:

  *No copyright* zlib/libpng
  BSD (3 clause)
  BSD (4 clause)
  BSD (4 clause) ISC
  GPL (v2 or later)
  ISC
  Unknown or generated
  zlib/libpng

[...]

> - Package does not contain duplicates in %files.
>   Note: warning: File listed twice: /usr/share/doc/sipxtapi/sipXcallLib
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

Indeed. Change the following from

  %files doc
  %doc %{_docdir}/%{name}/*
  %{_docdir}/%{name}/

to:

  %files doc
  %{_docdir}/%{name}/

What you wanted would be:

  %files doc
  %{_docdir}/%{name}/*
  %dir %{_docdir}/%{name}

Files below %_docdir are marked %doc automatically, btw.

[...]

Rpmlint (installed packages)
----------------------------
# rpmlint sipxtapi-doc sipxtapi sipxtapi-devel
sipxtapi-doc.x86_64: W: spelling-error %description -l en_US softphones -> soft
phones, soft-phones, sousaphones
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXmediaProcessing.so.1.0.0 /lib64/libssl.so.10
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXmediaProcessing.so.1.0.0 /lib64/libcrypto.so.10
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXmediaProcessing.so.1.0.0 /lib64/libpcre.so.1
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXmediaProcessing.so.1.0.0 /lib64/libdl.so.2
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXmediaProcessing.so.1.0.0 /lib64/libpthread.so.0
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXmediaProcessing.so.1.0.0 /lib64/libgsm.so.1
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXmediaProcessing.so.1.0.0 /lib64/librt.so.1
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXmediaProcessing.so.1.0.0 /lib64/libresolv.so.2
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXsdp.so.1.0.0 /lib64/libm.so.6
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXmedia.so.1.0.0 /lib64/libgsm.so.1
sipxtapi.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libsipXport.so.2.0.0 /lib64/libm.so.6
sipxtapi-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 13 warnings.
# echo 'rpmlint-done:'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c3sxKdHA5K&a=cc_unsubscribe