[Bug 995974] Review Request: libbson - BSON library for C

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=995974



--- Comment #7 from Joshua Small <technion at lolware.net> ---
To clarify my point..

The upstream has created a product which, by default, ships with -Werror.
Whether this is unhelpful is an issue for upstream.

If the product fails to even compile in a basic environment, this is an issue
far better addressed upstream (and one I'd imagine they'd be keen to see fixed)
than patched out at packaging time by disabling the error.

As far as review goes:

Obviously, the blocker here is waiting until it's stable.

I'm assuming that once a "stable" version is declared, you'll match the version
number and source0 accordingly.

The patch0 address in the .spec file just 404's on me - although I'm expecting
this to be redundant once this patch is incorporated.

This line:
rm -rf $RPM_BUILD_ROOT
Is obsolete and should no longer be used. See:
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

rpmlint hits up a few errors worth reviewing:
./libbson.spec:65: W: libdir-macro-in-noarch-package devel %{_libdir}/*.so
Several of the above errors. They make sense - if a file is noarch, would it
really belong in /usr/lib64, as per /usr/lib64/libbson-1.0.so?

libbson.x86_64: E: zero-length /usr/share/doc/libbson-0.1.10/NEWS
Get rid of this file if it doesn't ever have "news".

libbson-python.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/cbson.so.0.0.0 cbson.so.0()(64bit)

There's some documentation on this error here:
http://fedoraproject.org/wiki/Common_Rpmlint_issues#private-shared-object-provides

However, I'm unsure if your intention should involve filtering the library out,
or deliberately providing it.

I've run a koji build so others can review your build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5807541

You can review there full output for this error:
 FAILED: BuildError: mismatch when analyzing
libbson-devel-0.1.10-2.fc19.noarch.rpm

The errors shown may be related to the no arch issue above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bVCG7by0eA&a=cc_unsubscribe