[Bug 996042] Review Request: tinyxml2 - Simple, small and efficient C++ XML parser
bugzilla at redhat.com
bugzilla at redhat.com
Mon Aug 12 15:38:47 UTC 2013
https://bugzilla.redhat.com/show_bug.cgi?id=996042
--- Comment #3 from Susi Lehtola <susi.lehtola at iki.fi> ---
The chmod belongs in %prep (after %setup), not %build.
**
The statement
%cmake
should read
%cmake .
I have no idea why it would even run without a path statement.
Also, I would *really* recommend using a clean buildroot, as CMake is a modern
build system and supports out-of-root builds out of the box.
**
OT: I'm not quite sure why you'd want to explicitly state the minor soversion,
because it isn't even used by the dependency checkers.
===== MUST items =====
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
===== SHOULD items =====
Generic:
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: tinyxml2-1.0.11-2.20130805git0323851.fc18.x86_64.rpm
tinyxml2-devel-1.0.11-2.20130805git0323851.fc18.x86_64.rpm
tinyxml2.x86_64: W: spelling-error %description -l en_US eXtensible ->
extensible
tinyxml2-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
These are OK.
Rpmlint (installed packages)
----------------------------
# rpmlint tinyxml2 tinyxml2-devel
tinyxml2.x86_64: W: spelling-error %description -l en_US eXtensible ->
extensible
tinyxml2.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libtinyxml2.so.1.0.11 /lib64/libm.so.6
tinyxml2-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'
Please address the unused-direct-shlib-dependency issue.
Requires
--------
tinyxml2 (rpmlib, GLIBC filtered):
/sbin/ldconfig
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libm.so.6()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
rtld(GNU_HASH)
tinyxml2-devel (rpmlib, GLIBC filtered):
/usr/bin/pkg-config
libtinyxml2.so.1()(64bit)
tinyxml2(x86-64)
Provides
--------
tinyxml2:
libtinyxml2.so.1()(64bit)
tinyxml2
tinyxml2(x86-64)
tinyxml2-devel:
pkgconfig(tinyxml2)
tinyxml2-devel
tinyxml2-devel(x86-64)
Source checksums
----------------
https://github.com/leethomason/tinyxml2/archive/03238517b3718f0c977bb061747faa8ebfc4fb44/tinyxml2-1.0.11-0323851.tar.gz
:
CHECKSUM(SHA256) this package :
b5c4df98b44919435451770504401a1d4887e5e81e720686a5077d823149fdab
CHECKSUM(SHA256) upstream package :
b5c4df98b44919435451770504401a1d4887e5e81e720686a5077d823149fdab
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZiV82Pfx67&a=cc_unsubscribe
More information about the package-review
mailing list