[Bug 996311] Review Request: perl-CAD-Format-STL - Read and Write STL (STereoLithography) format files

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=996311



--- Comment #2 from John C Peterson <jcp at eskimo.com> ---
Spec URL: http://www.eskimo.com/~jcp/perl-CAD-Format-STL.spec
SRPM URL: http://www.eskimo.com/~jcp/perl-CAD-Format-STL-0.2.1-2.fc19.src.rpm

Hi Christopher,

Thanks for taking time out to review my package.

I believe I have addressed all the issues you raised in this new version.

Upon closer examination, I think the conditionals need to look like this;

%if 0%{?rhel}
%if 0%{?rhel} < 6
Do something special for RHEL5 and older...
%endif
%endif

The outer test is needed, because on non-RHEL systems like Fedora, the %{?rhel}
macro is not defined at all, so 0 < 6 evaluates to true on any non-RHEL system
which is not what was intended. (I verified this with a quick test case).

Regards, John

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9zAEV49S9D&a=cc_unsubscribe