[Bug 994434] Review Request: kompare - Diff tool

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=994434



--- Comment #10 from Rex Dieter <rdieter at math.unl.edu> ---
naming: ok

1. better url:
https://projects.kde.org/projects/kde/kdesdk/kompare

2. licensing, main pkg should be:
License: GPLv2+ and GFDL
add
%doc COPYING.DOC

(some parts of libdiff2 and headers are LGPLv2+, but they're combined with
GPLv2+, so aggregate is GPLv2+)

3. obsoletes/provides not ok
-libs subpkg missing
Obsoletes: kdesdk-kompare-libs < 4.10.80

macros: ok

4. %files not ok, move these from main to -devel pkg:
%{_kde4_libdir}/libkomparedialogpages.so
%{_kde4_libdir}/libkomparediff2.so
or delete/omit these symlinks from packaging altogether, as there is apparently
no api (ie, headers) associated with them (Kevin, correct me if you think this
is inaccurate).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R2cPfZgesm&a=cc_unsubscribe