[Bug 904843] Review Request: acpica-tools - ACPICA tools for the development and debug of ACPI tables

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=904843



--- Comment #44 from Peter Robinson <pbrobinson at gmail.com> ---
- rpmlint output

A few things to fix up here. Ignore the spelling-error. The main ones that need
attention are invalid-url, mixed-use-of-spaces-and-tabs and likely
setup-not-quiet.

acpica-tools.src: W: spelling-error %description -l en_US iasl -> ails, sail,
isl
acpica-tools.src: W: spelling-error %description -l en_US acpibin -> backspin
acpica-tools.src: W: spelling-error %description -l en_US acpidump -> dumpiness
acpica-tools.src: W: spelling-error %description -l en_US acpiexec -> apiece
acpica-tools.src: W: spelling-error %description -l en_US acpihelp -> perihelia
acpica-tools.src: W: spelling-error %description -l en_US acpinames ->
pinnacles
acpica-tools.src: W: spelling-error %description -l en_US acpisrc -> acropolis
acpica-tools.src: W: spelling-error %description -l en_US acpixtract ->
extraction
acpica-tools.src: W: spelling-error %description -l en_US pmtools -> pm tools,
pm-tools, tools
acpica-tools.src: W: strange-permission run-misc-tests.sh 0755L
acpica-tools.src:36: W: unversioned-explicit-provides acpixtract
acpica-tools.src:44: W: unversioned-explicit-provides acpidump
acpica-tools.src:76: W: setup-not-quiet
acpica-tools.src:103: W: macro-in-comment %{optflags}
acpica-tools.src:103: W: macro-in-comment %{_smp_mflags}
acpica-tools.src:44: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line
44)
acpica-tools.src: W: invalid-url Source1:
https://www.acpica.org/download/acpitests-unix-20130725.tar.gz HTTP Error 404:
Not Found
acpica-tools.src: W: invalid-url Source0:
https://www.acpica.org/download/acpica-unix2-20130725.tar.gz HTTP Error 404:
Not Found
acpica-tools.spec:36: W: unversioned-explicit-provides acpixtract
acpica-tools.spec:44: W: unversioned-explicit-provides acpidump
acpica-tools.spec:76: W: setup-not-quiet
acpica-tools.spec:103: W: macro-in-comment %{optflags}
acpica-tools.spec:103: W: macro-in-comment %{_smp_mflags}
acpica-tools.spec:44: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
line 44)
acpica-tools.spec: W: invalid-url Source1:
https://www.acpica.org/download/acpitests-unix-20130725.tar.gz HTTP Error 404:
Not Found
acpica-tools.spec: W: invalid-url Source0:
https://www.acpica.org/download/acpica-unix2-20130725.tar.gz HTTP Error 404:
Not Found
1 packages and 1 specfiles checked; 0 errors, 26 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
- license matches the actual package license

There is no included licence file at all and running a "licensecheck -r
acpica-unix2-20130725" produces a bunch of unknown and the following:
generate/unix/iasl/obj/ GPL (v3 or later)

+ latest version packaged

- %doc includes license file
+ spec file written in American English
+ spec file is legible
- upstream sources match sources in the srpm
  can't verify, source URL gives 404
+ package successfully builds on at least one architecture
  tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ Package perserves timestamps on install
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime 
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8

Optional:

+ if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
+ Package should have man files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TQIBk6t0w7&a=cc_unsubscribe