[Bug 999052] Review Request: perl-WWW-Splunk - Client library for Splunk log search engine

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=999052

Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|package-review at lists.fedora |
                   |project.org                 |
                 CC|                            |rc040203 at freenet.de



--- Comment #1 from Ralf Corsepius <rc040203 at freenet.de> ---
Basically OK, but these items:

1. Please remove these Requires:
Requires:       perl(Date::Manip)
Requires:       perl(HTTP::Request::Common)
Requires:       perl(LWP::UserAgent)
Requires:       perl(Test::More)
Requires:       perl(Text::CSV)   
Requires:       perl(XML::LibXML)

Modern rpm tracks run-time perl-module requirements automatically, which
reduces the packager's work-load and helps avoiding packaging mistakes.
e.g. The R: perl(Test::More) above is incorrect. It's not a run-time
requirement, but only a testsuite's requirement.

2. Consider to remove the rpm anachronisms from your spec (rm -rf
RPM_BUILD_ROOT, BuildRoot, defattr(), %clean ...).

I understand, your target distro is epel6, but even there most of them are not
needed anymore (AFAICT, they are still needed on epel5).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jwPStEBLu2&a=cc_unsubscribe