[Bug 912960] Review Request: rubygem-gdk3 - Ruby binding of GDK-3.x

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=912960



--- Comment #7 from Miroslav Suchý <msuchy at redhat.com> ---
>- Well, this is wrapper for gdk, and actually (if test fails)
>  debugging it sometimes takes really much times. Sometimes
>  even upstream can't fix this in a short time. So unless there
>  is apparently critical issue to fix, I want to just notice upstream
>  about test failure (if any).

Sounds reasonable. But only if the test is currently failing. I would like to
the there:
  ruby -Ilib:test ./test/run-test.rb
and if test will start fail, you can then *temporary* add 
 ... || echo "Know problem BZ XXX"
This way users (e.g provepackagers) will know why the failing test is waived
and can checkout the progress. You may want to add some comment for
provenpackagers, that if test is failing, you can temporary disable it this way
and report the problem at XXX.
Do you agree?


> * And neither of vendorarchhdrdir or /usr/include/vendor_ruby actually
>    does not work (in the meaning that they are not included in include
>    path) (see

Which is IMO bug in ruby. Filed bug 1001528.

And from different POV: why you are copying it to ruby_vendorarchdir? Why it
could not stay in %{gem_instdir}/lib/ ? You will probably then have to manualy
specify include in rubygem-gtk, but thats IMO not problem and big deal.
Opinions?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VNosyb53lg&a=cc_unsubscribe