[Bug 982351] Review Request: python-jsonpointer - Resolve JSON Pointers in Python

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=982351

Mario Blättermann <mario.blaettermann at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|package-review at lists.fedora |
                   |project.org                 |



--- Comment #6 from Mario Blättermann <mario.blaettermann at gmail.com> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5862403

$ rpmlint -i -v *
python-jsonpointer.noarch: I: checking
python-jsonpointer.noarch: I: checking-url
https://github.com/stefankoegl/python-json-pointer (timeout 10 seconds)
python-jsonpointer.src: I: checking
python-jsonpointer.src: I: checking-url
https://github.com/stefankoegl/python-json-pointer (timeout 10 seconds)
python-jsonpointer.src: I: checking-url
https://github.com/stefankoegl/python-json-pointer/archive/c1ec3dfd171b242e23b3fe078a99f0e23fb0c6ea/python-json-pointer-1.0-c1ec3df.tar.gz
(timeout 10 seconds)
python-jsonpointer.spec: I: checking-url
https://github.com/stefankoegl/python-json-pointer/archive/c1ec3dfd171b242e23b3fe078a99f0e23fb0c6ea/python-json-pointer-1.0-c1ec3df.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 0 warnings.


Referring to rpmlint, your package is OK. But shouldn't be the %check section
after %install? Maybe it is important to run the tests after installation. All
Python packages I've reviewed do so.

Moreover, I'm missing AUTHORS in %doc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1AkG8260oN&a=cc_unsubscribe