[Bug 1036319] Review Request: libnftables - Library for low-level interaction with nftables Netlink's API over libmnl

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1036319

Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |bugs.michael at gmx.net
           Assignee|nobody at fedoraproject.org    |bugs.michael at gmx.net
              Flags|                            |fedora-review+



--- Comment #1 from Michael Schwendt <bugs.michael at gmx.net> ---
* Both configure.ac and libnftables.pc contain version 1.0.0 already, symbol
versioning uses 1.0. If you're afraid of making this a 1.0.0 pre-release, use
Version "0", not "0.0". The extra .0 doesn't serve any purpose at all.


* Reproducing the git checkout resulted in a 2KB diff, updates to file xt_LOG.h
and nft-expr_target-test.c


* Build output is non-verbose. One cannot examine compiler flags'n'friends that
way. Add option  --disable-silent-rules  to the %configure call. That works
with the regenerated Autotools files.


* Relevant rpmlint output:

libnftables.x86_64: W: incoherent-version-in-changelog 0.0-0.1
['0.0-0.1.2013113
0git.fc20', '0.0-0.1.20131130git']
libnftables.x86_64: E: incorrect-fsf-address /usr/share/doc/libnftables/COPYING

https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address


* Directory "tests" contains stuff compiled by Make target "check" and run by
tests/test-script.sh. It could be worthwhile building that stuff in the %check
section. Here everything builds, and all test programs print "OK".


> %package        devel
> Group:          Development/Libraries

Either drop the Group tag here, or add one also to the base package (System
Environment/Libraries there).


> %install
> rm -rf $RPM_BUILD_ROOT

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag



* No real blockers during review. I highly recommend changing version to 0 and
enabling verbose build, at least. That could be done when importing into dist
git, however. So:

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component