[Bug 1036297] Review Request: python-libturpial - library needed to new turpial (twitter client) version

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 6 08:54:48 UTC 2013


https://bugzilla.redhat.com/show_bug.cgi?id=1036297



--- Comment #7 from Eduardo Echeverria <echevemaster at gmail.com> ---
(In reply to Christopher Meng from comment #6)
> 1. Please imporve the summary of this package but not leave it there by:
> 
> This library is the back-end used for Turpial.
> 
@cicku, you're right, indeed it is the turpial's backend, but if we take a look
in the app's setup.py, can we see 

setup(name="libturpial",
    version=VERSION,
    description="Microblogging library",

because that, I think that the short description can be =>
Microblogging python library, needed for turpial (twitter client)

@Richzendy, all the "tiny" modifications of the source (like as you used with
sed), have to doing in %prep section.

about the permissions, you can use

for file in `find %{buildroot}/%{python_sitelib}/%{name} -type f ! -perm /a+x
-name '*.py'`; do
    [ -z "`head -n 1 $file | grep \"^#!/\"`" ] && chmod -v a-x $file
done

Please remove the buildroot tag 
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
it is used just in el5, el5 has py24, libturpial doesn't works in py24, afaik


(In reply to Edwind Richzendy Contreras Soto from comment #5)
> (In reply to Eduardo Echeverria from comment #3)
> I need patch the source code to make this, because the path to this cert
> file appears in one source file (lib/http.py) and one binary file
> (lib/http.pyo), it's fine do it? 

Yes you can do it. via patch tag, see
http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25prep_section:_.25patch_commands

Just have to modify **basedir** variable

        else:
            basedir = os.path.dirname(__file__) <== modify
            self.ca_certs_file = os.path.realpath(os.path.join(basedir,
                '..', 'certs', 'cacert.pem'))

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list