[Bug 1038128] Review Request: libeot - a library for parsing Embedded OpenType font files

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1038128

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody at fedoraproject.org    |panemade at gmail.com
              Flags|                            |fedora-review+



--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> ---
Review:
+ mock build for rawhide is successful

+ rpmlint on generated rpms 
libeot-devel.x86_64: W: no-documentation
libeot-tools.x86_64: W: no-documentation
libeot-tools.x86_64: W: no-manual-page-for-binary eot2ttf
5 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ source verified with upstream as sha256sum
srpm tarball     :
cf5091fa8e7dcdbe667335eb90a2cfdd0a3fe8f8c7c8d1ece44d9d055736a06a
upstream tarball :
cf5091fa8e7dcdbe667335eb90a2cfdd0a3fe8f8c7c8d1ece44d9d055736a06a

+ License is valid and included in LICENSE file


suggestion:
1) header file timestamp can be preserved if used 
make install DESTDIR=%{buildroot} INSTALL="install -p"

2) build.log showing
configure: WARNING: unrecognized options: --disable-werror

so remove that option to ./configure
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component