[Bug 974852] Review Request: fish - A Friendly Interactive SHell

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 11 19:19:44 UTC 2013


https://bugzilla.redhat.com/show_bug.cgi?id=974852

Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugs.michael at gmx.net        |



--- Comment #14 from Michael Schwendt <bugs.michael at gmx.net> ---
> There's one rpmlint error about mktemp.  The code in question actually
> appears to be secure -- it calls mktemp and then opens the file with
> O_CREAT | O_EXCL.  This is silly (it should use mkostemp), but it
> appears to be safe.

> Why is it mkstemp 'silly' when it uses the correct flags?

The code calls mktemp, which is insecure. It ought to call mkstemp instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list