[Bug 1040459] Review Request: NetworkManager-iodine - iodine VPN plugin for NetworkManager

Thu Dec 12 15:44:00 UTC 2013

https://bugzilla.redhat.com/show_bug.cgi?id=1040459

Simon Farnsworth <simon at farnz.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon at farnz.org.uk

--- Comment #1 from Simon Farnsworth <simon at farnz.org.uk> ---
I'm not a packager yet (see bug 1034341 if you're a sponsor willing to work
with me), so this is not a proper review, but I hope it'll help the final
reviewer.

Search for [!] to find the faults, and [?] for the things I didn't check
properly.

Quick summary:

 * Your Requires don't seem to take account of autorequires.
 * Upstream has obsolete m4 macros - reported in their bugtracker?
 * I've not tested that the package works - just that it looks good.
   * As part of this, does a 32-bit NetworkManager-iodine-gnome work with a
     64-bit NetworkManager-iodine? If not, please tighten up the Requires to
     include %{?_isa} too.
 * You're checking out a tarball snapshot from git, when upstream provide
   release tarballs at
   http://honk.sigxcpu.org/projects/network-manager-iodine/tarballs/
   * If you used a release tarball directly, your Release: line would be
     simpler and you could get rid of the "checkout" macros at the top.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[-]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
     Several of your requires appear unnecessary, as autorequires will pull
them in.
     gtk3 is definitely pulled in by autorequires; how much of gnome-keyring
     and dbus do you actually need? Do you need shared-mime-info at all?

     See https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     NetworkManager-iodine-gnome

     However, there is a %{name} = %{version}-%{release}; if an i686
     NetworkManager-iodine-gnome works with an x86_64 NetworkManager-iodine,
     this requirement is met. I've not checked this.

[?]: Package functions as described.
     Untested.

[!]: Latest version is packaged.
     You package a git snapshot from the 0.0.4 tag and alter Release: to match
     this - why? Why not take a release tarball from
     http://honk.sigxcpu.org/projects/network-manager-iodine/tarballs/
directly?
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Package should not use obsolete m4 macros
     Note: Some obsoleted macros found, see the attachment.
     See: https://fedorahosted.org/FedoraReview/wiki/AutoTools

     Perhaps a pointer to an upstream bug about this?

[x]: Rpmlint is run on all installed packages.
     The messages appear reasonable.

[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: NetworkManager-iodine-0.0.4-0.1.20131210gita2a90c6.fc21.x86_64.rpm

NetworkManager-iodine-gnome-0.0.4-0.1.20131210gita2a90c6.fc21.x86_64.rpm
          NetworkManager-iodine-0.0.4-0.1.20131210gita2a90c6.fc21.src.rpm
NetworkManager-iodine.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/nm-iodine-service.conf
NetworkManager-iodine.x86_64: W: non-conffile-in-etc
/etc/NetworkManager/VPN/nm-iodine-service.name
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint NetworkManager-iodine-gnome NetworkManager-iodine
NetworkManager-iodine.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/nm-iodine-service.conf
NetworkManager-iodine.x86_64: W: non-conffile-in-etc
/etc/NetworkManager/VPN/nm-iodine-service.name
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'

AutoTools: Obsoleted m4s found
------------------------------
  AC_PROG_LIBTOOL found in: network-manager-iodine-0.0.4/configure.ac:17

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/bin/fedora-review -b 1040459 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component