[Bug 1023848] Review Request: closure-compiler - JavaScript minifier and checker

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1023848



--- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> ---
So, a new version:

Spec URL: http://in.waw.pl/~zbyszek/fedora/closure-compiler.spec
SRPM URL:
http://in.waw.pl/~zbyszek/fedora/closure-compiler-20131118-1.fc19.src.rpm

Upstream has released a new version, so the package is updated to it.

There were bugs in the spec. The worst thing was that tools/maven-ant-tasks.jar
was bundled (used during build). Using the system-wide one proved hard, because
the
build would crash with an obscure (for me) traceback. I read on the net that
this is because of incompatibility of maven-ant-tasks with maven3. Maybe.
The problem was easy enough to work around by removing one line from build.xml
which copies pom to build/, which is later unused anyway.

(In reply to Dridi Boukelmoune from comment #4)
> I have a failing build on koji [1] which basically fails the same way when I
> run locally fedora-review with mock configured with rawhide.
> 
> The error message is:
> > /usr/bin/build-jar-repository: Could not find json Java extension for this JVM
> > /usr/bin/build-jar-repository: Could not find findbugs Java extension for this JVM
> > /usr/bin/build-jar-repository: error: Some specified jars were not found for this jvm
This should be fixed.

But please note that the build will fail later because newer guava is required.
If
I'm reading things correctly,
http://koji.fedoraproject.org/koji/taskinfo?taskID=6258651
is done with guava 13.

> Also I was wondering whether it is normal on rawhide to see fc20 dist tags
> [3] in dependencies:
> > DEBUG util.py:266:  Getting requirements for closure-compiler-20131014-2.fc21.src
> > DEBUG util.py:266:   --> javapackages-tools-3.4.1-3.fc21.noarch
> > DEBUG util.py:266:   --> 1:java-1.7.0-openjdk-devel-1.7.0.60-2.4.3.1.fc21.x86_64
> > DEBUG util.py:266:   --> ant-1.9.2-7.fc21.noarch
> > DEBUG util.py:266:   --> maven-ant-tasks-2.1.3-4.fc20.noarch
> > DEBUG util.py:266:   --> jarjar-1.4-6.fc21.noarch
> > DEBUG util.py:266:   --> args4j-2.0.25-1.fc20.noarch
> > DEBUG util.py:266:   --> guava-13.0-6.fc20.noarch
> > DEBUG util.py:266:   --> android-json-org-java-4.3-0.1.r3.1.fc21.noarch
> > DEBUG util.py:266:   --> jsr-305-0-0.16.20130910svn.fc21.noarch
> > DEBUG util.py:266:   --> junit-4.11-7.fc21.noarch
> > DEBUG util.py:266:   --> protobuf-java-2.5.0-5.fc20.x86_64
> > DEBUG util.py:266:   --> rhino-1.7R4-6.fc21.noarch
No idea.

Package builds correctly for me now, also in mock, if I ensure that guava 15 is
installed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component