[Bug 1012392] Review Request: nanomsg - nanomsg is a socket library that provides several common communication patterns

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1012392



--- Comment #8 from Zoltan Boszormenyi <zboszor at pr.hu> ---
Sorry it took me this long to get back to this task.

(In reply to Haïkel Guémar from comment #6)
> I was planning to package it but i got delayed by an event as fp.o
> ambassador (where i gave a talk on nanomsg:) )
> Good point, it passed the scratch build test:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=6029041
> 
> I'm a sponsor, i can take care of that part if you agree.
> For a beginning, start by doing two informal reviews (please, put me in CC)
> and link them in this ticket.

I'll do that later today or tomorrow.

> I'll also drill you on some fedora packaging guidelines, either by mail or
> irc.
> 
> 1. Group tags are not required anymore, remove them

Done.

> 2. Release tag is not handled correctly for a pre-release, it should be
> something like 
> %global alphatag alpha
> Release: O.3%{alphatag}
> Please read the following guideline:
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-
> Release_packages

How about the git commit number and git date?
I rebased to the current GIT version.

> 3. for the url: http://nanomsg.org

Fixed.

> 4. Remove the requires on nanomsg in the nanocat subpackage, RPM can compute
> that dependency

Done.

> 5. i'd rather rename the nanocat subpackage into tools or utilities, other
> CLI might show up in the future.'

Done.

> 6. the description is way too long and not helpful for fedora users. Please
> *trim it* and make it *useful*.

Done.

> 7. Did you submit your patches upstream ? If you did, please provide a link
> to the upstream ticket, if you didn't, please send them.
> When you're done, put a comment on top of the patch with the url of the
> upstream ticket.

I sent them long ago, but they were not appropriate, since nanomsg is also
build with Visual Studio (via cmake) and it doesn't understand certain
constructs. My patches were GCC-only.

I have created a new patch, sent it upstream and created the issue:

https://github.com/nanomsg/nanomsg/issues/208

My mail reporting the problem and the patch is at:

http://www.freelists.org/post/nanomsg/Warning-fixes,7

> 8. for the devel package, put the %doc first, ordering lines in %files
> section improves spec readability

Done.

> 9. You shouldn't specify the compression format for man pages, if we change
> it later, your spec will break. As i have a FPC member who backed me on that
> point so i'll make it a MUST ;)

Done.

> 10. for the Summary, i suggest: "A socket library for high-performance
> message-passing application" which is a more descriptive one-liner

Done.

Spec URL: http://boszormenyi.dyndns.biz/nanomsg.spec
SRPM URL:
http://boszormenyi.dyndns.biz/nanomsg-0.2-0.3.20131217git624c483.fc20.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component