[Bug 1047014] Review Request: python-blockdiag - Generate block-diagram images from text

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1047014

Dridi Boukelmoune <dridi.boukelmoune at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |python-blockdiag -          |python-blockdiag - Generate
                   |blockdiag generates         |block-diagram images from
                   |block-diagram image from    |text
                   |text                        |



--- Comment #2 from Dridi Boukelmoune <dridi.boukelmoune at gmail.com> ---
(In reply to Christopher Meng from comment #1)
> [!]: Sources can be downloaded from URI in Source: tag
>      Note: Could not download Source0:

> https://pypi.python.org/packages/source/b/blockdiag/blockdiag-1.3.2.tar.gz
>      See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags

This is strange, it definitely works for me.

curl --head -i
https://pypi.python.org/packages/source/b/blockdiag/blockdiag-1.3.2.tar.gz
HTTP/1.1 200 OK
Date: Tue, 31 Dec 2013 07:29:50 GMT
Server: Apache
Content-Type: application/x-gzip
Last-Modified: Tue, 19 Nov 2013 10:03:21 GMT
Cache-Control: max-age=86400, public
X-PYPI-LAST-SERIAL: 923425
Strict-Transport-Security: max-age=31536000
Content-Length: 134482
Accept-Ranges: bytes
Age: 0

> python-blockdiag.noarch: W: summary-not-capitalized C blockdiag generates
> block-diagram image from text
> 
> ---> Please fix.

Upstream doesn't capitalize the *diag tools names (like systemd) so I have
slightly changed the summary to comply.

> Nearly APPROVED:
> 
> 1. BuildRequires:  python-devel --> BuildRequires:  python2-devel
> 
> 2. %{__python} --> %{__python2}

Fixed, except line 64 which doesn't use python2 in the guidelines:
find -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python}|'

Spec URL:
https://bitbucket.org/dridi/fedora_packages/downloads/python-blockdiag.spec
SRPM URL:
https://bitbucket.org/dridi/fedora_packages/downloads/python-blockdiag-1.3.2-2.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component