[Bug 907213] Review Request: lmfit - Levenberg-Marquardt least-squares minimization and curve fitting

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=907213

Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de

--- Comment #2 from Ralf Corsepius <rc040203 at freenet.de> ---
Some comments:

1. You can't package the demo binaries into /usr/share/doc/*, because all files
below /usr/share must be arch-independent.

I'd recommend to do one of the following:
a) To only ship the sources (*.c) under /usr/share/doc/*
b) To install the demos somewhere below %{_libdir}/lmfit in a separate *-demos 
package (One way to do so would be to use %configure
--bindir=%{_libdir}/lmfit.)
c) To apply --program-prefix
d) Not to ship the demos.

2. Consider appending --disable-static to %configure.
This would avoid much of the "rm"-sequence you are using to remove the static
libs and would avoid compiling the libraries twice.

3. The %check section is superflous.
%check is supposed to run a testsuite, but this package doesn't ship one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p0FvxhAlHJ&a=cc_unsubscribe