[Bug 886903] Review Request: xonotic - Multiplayer, deathmatch oriented first person shooter

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886903

--- Comment #27 from Simone Caronni <negativo17 at gmail.com> ---
Issues:

=====

[!]: %build honors applicable compiler flags or justifies otherwise.

I've tried building with %{?_smp_mflags} and it builds fine, you can remove
comment at line 130 and add %{?_smp_mflags} to line 131/132.

=====

[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later) (with incorrect FSF address)", "BSD (2 clause)", "GPL
     (v2 or later)", "LGPL (v2 or later) (with incorrect FSF address)",
     "Unknown or generated". 5 files have unknown license.

According to the license check, a source file has a BSD license. I think the
License tag should be:

License: GPLv2+ and LGPLv2+ and BSD

http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

=====

[!]: Spec use %global instead of %define.
     Note: %define _hardened_build 1

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE

=====

xonotic.src:46: W: unversioned-explicit-provides nexuiz
xonotic.x86_64: W: self-obsoletion nexuiz <= 2.5.2 obsoletes nexuiz

Line 46 should be:

Provides: nexuiz = %{name}-%{version}

In addition to this, following the same logic the server subpackage should
have:

Obsoletes: nexuiz-server <= 2.5.2
Provides: nexuiz-server = %{name}-%{version}

It should be possible to run both old and new servers at the same time, but
this is the same approach as the base game; so if we obsolete nexuiz, also the
unmantained nexuiz-server should be obsoleted.

=====

xonotic.src:124: W: macro-in-comment %{__make}
xonotic.src:176: W: macro-in-comment %{buildroot}
xonotic.src:176: W: macro-in-comment %{_bindir}
xonotic.src:212: W: macro-in-comment %{_bindir}

As in comment #18, also those should be replaced with system commands, in case
they are later uncommented. Also %{_make} should be replaced with make.

=====

xonotic.src:141: W: mixed-use-of-spaces-and-tabs (spaces: line 33, tab: line
141)

You can remove one space at line 33 and 35 and replace the tabs with spaces
from line 141 onwards.

=====

xonotic.x86_64: W: incoherent-version-in-changelog 0.6.0-3 ['0.6.0-4.fc18',
'0.6.0-4']

Bump release in changelog to 0.6.0-4.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BALNIaqgVd&a=cc_unsubscribe