[Bug 893165] Review Request: mod_qos - Quality of service module for Apache

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=893165

--- Comment #2 from Christof Damian <christof at damian.net> ---
(In reply to comment #1)
> NOTES:
> 1) GPLv2 should be GPLv2+
> 2) This message always appears when run on machines not containing
> httpd-devel: "cat: /usr/include/httpd/.mmn: No such file or directory" which
> is only a minor issue but I assume that's not desired and instead the echo
> message should be present.
> 3) rm -rf $RPM_BUILD_ROOT present but not required
> 
> Over all, this looks good. It's nice and clean, just need those couple fixes.

I uploaded a new version fixing these issues.

I usually keep 3) in, because it doesn't hurt and makes it compatible with
EPEL-5, but I am not sure I will build this for that release anyway. 

Spec URL: http://rpms.damian.net/SPECS/mod_qos.spec
SRPM URL: http://rpms.damian.net/SRPMS/mod_qos-10.13-4.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uJCILT3iI2&a=cc_unsubscribe