[Bug 911188] Review Request: nodejs-should - A test framework agnostic BDD-style assertions for Node.js

bugzilla at redhat.com bugzilla at redhat.com
Sun Feb 24 16:31:05 UTC 2013


Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=911188

--- Comment #3 from Tom Hughes <tom at compton.nu> ---
Yes, the deepEqual thing is all a bit of a mess... The history seems to be
something like this:

* buffer comparison added to assert._deepEqual in Sep 2010
* lib/eql.js code copied from assert to should in Nov 2010
* lib/eql.js changed to do strict comparison in Sep 2011
* regexp comparison added to assert._deepEqual in Dec 2011
* deep-equal npm created in Feb 2012

Both the buffer comparison and regpext comparison seem to have been removed
when deep-equal was created however (or maybe it was copied from an older
version of node).

So the end result is that none of the three are now the same...

I'm not sure what the solution is, other than applying for an exception,
presumably on this basis:

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Modified_beyond_a_certain_extent

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hc87IR2Tyy&a=cc_unsubscribe



More information about the package-review mailing list