[Bug 863796] Review Request: printrun - RepRap printer interface and tools

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863796

Miro Hrončok <mhroncok at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(mhroncok at redhat.c |
                   |om)                         |
              Flags|                            |needinfo?(me at petetravis.com
                   |                            |)

--- Comment #13 from Miro Hrončok <mhroncok at redhat.com> ---
(In reply to comment #12)
> I'd like to tackle this review, assuming you have a sponsor.
Yes I have, you can check such things here:
https://admin.fedoraproject.org/accounts/group/members/packager/*

> Please bear
> with me - I'm new at this, but I'm not afraid to ask for help :)
Don't worry, we are both new at this :)

> Cited license is AGPLv3, but the included COPYING file is GPLv3.  These
> should match.
My fault, I probably left it there when creating the spec from another spec.

> Not all included files use the same licence, and some files do not declare a
> license.
I'll investigate this.

> The relationship between `printrun` and `skeinforge` is a little confusing.
> The SPEC for printrun looks like it is working with skeinforge files and
> directories. You'll want to make sure there are no conflicts between these
> related packages.
Well, the only thing that is done with Skeinforge is (or should be, feel free
to check it) changing the path where Printrun looks for Skeinforge from
relative skeinforge dir (inside printrun dir) to absolute path in system
(/usr/lib/...).
This should be harmless, because the skeinforge package is required.

> There are no upstream URLs for Source1, Source2, Source3. All sources should
> have a valid URL.
Those are mine. Consider them as part of the SRPM/spec.

> You're using the generated pronterface.lang with the common package; it
> should probably go with the pronterface files
It might seem so, but it contains strings for both pronterface and pronsole.

> rpmlint complains about macros in changelog; you probably don't need to be
> so specific about the change made.
I forgot to %%comment them out. Will do that.

> The locales loop is failing in my build log, you should investigate.
Could you please show me the log?

> I hope this helps get the ball rolling, will check in again soon.
Thanks a lot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=69e17vlOJ2&a=cc_unsubscribe