[Bug 863793] Review Request: skeinforge - Converts 3D model into G-Code for RepRap

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863793

T.C. Hollingsworth <tchollingsworth at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #21 from T.C. Hollingsworth <tchollingsworth at gmail.com> ---
In the future, please bump Release even if there are no spec changes, just SRPM
changes.  It's really easy to do (especially if you use `rpmdev-bumpspec`),
eliminates the chance of mistakes like the wget thing you mentioned, and is a
required part of the review process.

rpmlint is almost clean, except for the "macro-in-%changelog %doc" issue. 
(Sorry, I forgot to call attention to that in the last comment.)  Please fix
that in git.

To reduce the chance of things like the problematic executable permission from
happening in the future, consider explicitly setting the permissions of
packager-provided SourceN files upon install, e.g. by doing `install -Dpm0755
%{SOURCE7} %{buildroot}%{_bindir}/foo`.

This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lSXV5zDyLG&a=cc_unsubscribe