[Bug 895226] Review Request: python-django-grappelli - A jazzy skin for the Django admin interface

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895226

--- Comment #1 from Eduardo Echeverria <echevemaster at gmail.com> ---
Hi Luis

Don't needed remove these files:
find . -name "*.js" -exec  rm -rfv '{}' \;

I removed this line and this is what rpmlint complains (e.g):

python-django-grappelli.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/grappelli/static/grappelli/tinymce/jscripts/tiny_mce/themes/advanced/langs/en_dlg.js
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.
.........

this can be solved with these lines:

for file in `find %{buildroot}/%{python_sitelib}/grappelli -type f  -perm /a+x
-name '*.js'`; do
        chmod -v a-x $file
done

what is your intention in removing these files?
rm -rf grappelli/static/admin/js/compress.py
rm -rf grappelli/models.py
rm -rf
grappelli/static/grappelli/jquery/ui/css/custom-theme/jquery-ui-1.8.18.custom.css
rm -rf grappelli/static/grappelli/stylesheets/mueller/screen.css

In the LICENSE file can be read: 
django-grappelli contains code from django-admin-tools

I think we're in a bundling problem here, the url of this project is [1]
Identify files that might be affected by the "bundling" and try to do a patch
to solve this issues or try to ask for an exception to fpc [2]

This package also bundle jquery, although I think we can do nothing here for
now, There is a stalled packaging guideline draft about JavaScript libraries
[3]

[1] https://bitbucket.org/izi/django-admin-tools/overview
[2] https://fedorahosted.org/fpc/
[3]
https://fedoraproject.org/wiki/JavaScript_libraries_packaging_guideline_draft

and jquery package has tried getting into Fedora several times without success
more information in:

- bug 457343
- bug 805587
- bug 857992


There is documentation to generate in this package, if you find it useful and
interesting please add it to the package, need python-sphinx as BR

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pFGeLGqJ51&a=cc_unsubscribe