[Bug 891182] nodejs-chownr - Like `chown -R`

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891182

Miro Hrončok <mhroncok at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #6 from Miro Hrončok <mhroncok at redhat.com> ---
TODO: Drop markdown syntax from Description.

MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.

$ rpmlint ../SRPMS/nodejs-chownr-0.0.1-6.fc18.src.rpm
../RPMS/noarch/nodejs-chownr-0.0.1-6.fc18.noarch.rpm
nodejs-chownr.src: W: spelling-error %description -l en_US chown -> sown, chow,
chows
nodejs-chownr.noarch: W: spelling-error %description -l en_US chown -> sown,
chow, chows
nodejs-chownr.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

All are false positive. OK

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK

Checked in LICENSE: BSD, OK.

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.

$ sha256sum ../SOURCES/chownr-0.0.1.tgz 
da1fbb894b4103a1a3c912fc780f6dcf7339865298f2fdc4e20afdf00a94b821 
../SOURCES/chownr-0.0.1.tgz
$ spectool -g nodejs-chownr.spec 
Getting http://registry.npmjs.org/chownr/-/chownr-0.0.1.tgz to
./chownr-0.0.1.tgz
$ sha256sum chownr-0.0.1.tgz 
da1fbb894b4103a1a3c912fc780f6dcf7339865298f2fdc4e20afdf00a94b821 
chownr-0.0.1.tgz

OK

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.

$ rpm -q -lv -p ../RPMS/noarch/nodejs-chownr-0.0.1-6.fc18.noarch.rpm 
drwxr-xr-x    2 root    root                        0 led 15 20:42
/usr/lib/node_modules/chownr
-rw-r--r--    1 root    root                     1087 bře 29  2012
/usr/lib/node_modules/chownr/chownr.js
drwxr-xr-x    2 root    root                        0 led 15 20:42
/usr/lib/node_modules/chownr/node_modules
-rw-r--r--    1 root    root                      413 čen  4  2012
/usr/lib/node_modules/chownr/package.json
drwxr-xr-x    2 root    root                        0 led 15 20:42
/usr/share/doc/nodejs-chownr-0.0.1
-rw-r--r--    1 root    root                     1318 čen  4  2012
/usr/share/doc/nodejs-chownr-0.0.1/LICENCE
-rw-r--r--    1 root    root                       59 bře 28  2012
/usr/share/doc/nodejs-chownr-0.0.1/README.md

OK

MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK

SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK

TODO: Run tests, when deps reach Fedora

Please consider fixing TODOs. Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Swoiffn4sc&a=cc_unsubscribe