[Bug 876408] Review Request: perl-Boost-Geometry-Utils - Boost::Geometry::Utils Perl module

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=876408

--- Comment #4 from Petr Šabata <psabata at redhat.com> ---
(In reply to comment #3)
> The action is more obvious (readable) in the spec, I suppose.
> 
> When reading the spec over again, some part of my brain remembered, someone
> has told me once to use dos2unix instead of sed. It's part of my
> subconscious now.

It's mostly a matter of style.  I was just curious.

Issues found while looking at your package:

Missing build-time dependencies:
perl(File::Temp) (from t/00-compile.t:11)
perl(Exporter) (from lib/Boost/Geometry/Utils.pm:9)
perl(XSLoader) (from lib/Boost/Geometry/Utils.pm:12)

You can drop the following deps as they aren't actually used anywhere:
perl(ExtUtils::Typemaps::Default)
perl(ExtUtils::XSpp)
perl(Module::Build)

What's the point of including the 'src' directory in the documentation?
If you really want to package it, consider putting it in a doc subpackage.  My
guess is the package users probably won't need those 31MiB installed.  The same
applies to the xsp directory, even though it's quite small.
If you're going to keep these, also change the License tag to "(GPL+ or
Artistic) and Boost and MIT".

And...
(In reply to comment #1)
> - Dropped perl macro
You could also drop it in the MODULE_COMPAT virtual dependency line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1U4Pe59hsj&a=cc_unsubscribe