[Bug 877694] Review Request: hidapi - Library for communicating with USB and Bluetooth HID devices

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877694

--- Comment #1 from Michael Schwendt <mschwendt at gmail.com> ---
There are a couple of minor mistakes in the spec file:

> Version:        0.7.0
> Release:        0.20120921git85d608e%{?dist}

According to  https://github.com/signal11/hidapi/downloads  there is a 0.7.0
release, "uploaded a year ago". So, your snapshot can should apply the
post-release versioning scheme, where the "Release" tag typically starts with
"1" not "0":

  Release:        1.20120921git85d608e%{?dist}

https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

For Fedora packages, the "0." release prefix is special and used for
pre-release packages only.


> # The source was created from GIT repository
> Source0:        http://www.ozancaglayan.com/fedora/SOURCES/%{name}-
> %{version}.20120921git85d608e.tar.bz2

https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
|
| There are several cases where upstream is not providing the source
| to you in an upstream tarball. In these cases you must document how
| to generate the tarball used in the rpm either through a spec file
| comment or a script included as a separate SourceX:. 


> Summary:        A library for communicating with USB and Bluetooth HID devices

In package tools like GNOME PackageKit or installers like Anaconda these
leading articles reduce readability. Omitting them makes summaries even more
concise. Imagine dozens/hundreds of package summaries starting with "A", "An,
"The". This is superfluous.


> %package -n hidapi-devel
> Summary: Development files for hidapi

Surprise! :-)  Here you didn't write "The development files for hdiapi" either.
Good!


> %package -n hidapi-devel
> Requires: hidapi = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> Requires: pkgconfig

Nowadays there are automatic Provides/Requires for pkg-config file details.


> %install
> rm -rf $RPM_BUILD_ROOT

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag


* Would it make sense to generate and package the API documentation using
Doxygen?


>  CC       hid.lo
>  CCLD     libhidapi-hidraw.la

Could you enable verbose build output by passing V=1 to "make"? That makes the
build log more useful as one could see the preprocessor/compiler/linker flags,
for example.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PTMVBd6yb4&a=cc_unsubscribe