[Bug 896310] Review Request: odeint - A C++ library for numerically solving Ordinary Differential Equations

bugzilla at redhat.com bugzilla at redhat.com
Sun Jan 20 19:50:41 UTC 2013


Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896310

--- Comment #2 from Michael Schwendt <mschwendt at gmail.com> ---
> %global     checkout_date   20130117
> Name:           odeint
> Version:        2.2.%{checkout_date}
> Release:        1%{?dist}

It ought to apply the versioning scheme for snapshots.


> %description

Is that a copy of the complete README? *grin*

I highly recommend trimming it down to at most half the current size and
truncating the src.rpm description a lot, too.


> cp -rv

Typically, we want to preserve timestamps by using cp -p…


> %package devel
> Provides:   %{name} = %{version}-%{release}

> %package docs
> Requires:   %{name} = %{version}-%{release}

This extra dependency increases the metadata and isn't really useful, because
it is a virtual package only. You could simply depend on the -devel package.


* As the headers in the  -devel package are pretty much useless without Boost
headers, some dependencies on  the needed Boost -devel packages would be very
useful.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LgB6DJEJBo&a=cc_unsubscribe


More information about the package-review mailing list