[Bug 903766] New: Review Request: php-PhpOption - Option type for PHP

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 24 19:44:27 UTC 2013


Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=903766

            Bug ID: 903766
           Summary: Review Request: php-PhpOption - Option type for PHP
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Reporter: shawn.iwinski at gmail.com

Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PhpOption.spec

SRPM URL:
http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PhpOption-1.1.0-1.fc18.src.rpm

Description:
This package adds an Option type for PHP.

The Option type is intended for cases where you sometimes might return a value
(typically an object), and sometimes you might return no value (typically null)
depending on arguments, or other runtime factors.

Often times, you forget to handle the case where no value is returned. Not
intentionally of course, but maybe you did not account for all possible states
of the system; or maybe you indeed covered all cases, then time goes on, code
is refactored, some of these your checks might become invalid, or incomplete.
Suddenly, without noticing, the no value case is not handled anymore. As a
result, you might sometimes get fatal PHP errors telling you that you called a
method on a non-object; users might see blank pages, or worse.

On one hand, the Option type forces a developer to consciously think about both
cases (returning a value, or returning no value). That in itself will already
make your code more robust. On the other hand, the Option type also allows the
API developer to provide more concise API methods, and empowers the API user in
how he consumes these methods.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Tc5KaCa4hZ&a=cc_unsubscribe



More information about the package-review mailing list